Fix frozen TaskFailedEvent mutation in workforce failure handling#1128
Open
LuoPengcheng12138 wants to merge 1 commit intomainfrom
Open
Fix frozen TaskFailedEvent mutation in workforce failure handling#1128LuoPengcheng12138 wants to merge 1 commit intomainfrom
LuoPengcheng12138 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a runtime error caused by mutating a
Pydantic frozenevent model. InWorkforce._handle_failed_task, we created aTaskFailedEventand then attempted to set worker_id and failure_count afterward. CAMEL’s event models are ConfigDict(frozen=True, extra='forbid'), so post‑creation assignment raises ValidationError: Instance is frozen.The fix passes worker_id directly in the constructor and moves failure_count into metadata, which is an allowed field. This keeps the event immutable and avoids the validation error during failure handling.
What is the purpose of this pull request?